feat: add bool datatype#165
Merged
Merged
Conversation
f8e89a6 to
88f46bd
Compare
Collaborator
Author
chen2021673
reviewed
Jun 12, 2026
Contributor
|
kNcclDtypeMap 也需要加一下 DataType::kBOOL |
Contributor
|
感觉 Fill、Slice、Concat、Split、Stack 这几个算子应该支持 bool。这个可以单独另提 PR 修改。 |
Collaborator
Author
nccl 没有 bool 对应的类型,这里暂时先不加,等之后支持 ep 时再看下是通信前 cast 成 numerical type 还是按 uint8 做通信。 |
Collaborator
Author
理论上这类不涉及数值计算的算子确实都应该支持 bool。不过目前还没有模型路径覆盖到这些场景(mask 相关逻辑可能用到,但同时也需要配套修改上层模型实现),因此暂时没有一起放进这个 PR。 当前这个 PR 只为 Cast Kernel 增加了 bool 支持,因为 MoE 流程依赖对 bool 类型的 cast 转换,并且相关功能已经完成验证。其余算子的 bool 支持可以后续需要时单独提交 PR 补齐。 |
e313196 to
1b52547
Compare
…alid dtype dispatch macro for scatter forward
1b52547 to
8b37a2b
Compare
Collaborator
Author
|
补充了 #164 合入后本 pr 需要对 scatter.cu 同步的修改。 |
Collaborator
Author
chen2021673
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





#153 前置 pr,主要内容:添加 Bool DataType 类型。