test: revert short-history p2 heading to h3 (corrects #598 misread)#600
Merged
Conversation
PR #598 changed p2's level pin from h3 to h2 based on a misread of the rendered HTML: I was using grep over the whole response and mistakenly attributed <h2 class="tei-head7"> elements from the sibling <aside> sidebar to #content-inner. A properly scoped HTML parse of both localhost (HSG_ENV=production build) and the prod-preview3 Jenkins target shows the same structure inside #content-inner: <h3>Foundations of Foreign Affairs, <h4>Contents There is no <h2> inside #content-inner, which is why 3.11.3's Jenkins run failed with `#content-inner h2 still not existing after 10000ms` -- the new pin had nothing to match. The original p2 Jenkins failure that motivated #598 was a cold-cache timing flake, already mitigated by the waitForExist wrapper added in 33b5890. Revert the level change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joewiz
added a commit
that referenced
this pull request
May 13, 2026
3.11.3 shipped with a broken test spec that caused Jenkins to fail on the prod-preview3 target. PR #600 reverted that spec but its sole commit was test:, which doesn't trigger semantic-release. The hsg-publish deployment system can only deploy released versions, so cut 3.11.4 with this empty fix: commit to make the corrected master available downstream. The .xar artifact is byte-identical to 3.11.3 (test files are not packaged); only the test spec on master has changed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
🎉 This PR is included in version 3.11.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/specs/departmenthistory/prod_shorthistory_titles.spec.jsp2levelfromh2back toh3.element ("#content-inner h2") still not existing after 10000ms.Why
PR #598 changed p2's level pin from
h3toh2based on a misread of the rendered HTML. I used a flatgrep/awkover the whole response, which over-matched past#content-inner's closing tag and picked up<h2 class="tei-head7">elements from the sibling<aside>sidebar.Re-parsing both servers with proper HTML scope (balanced div matching via Python's HTMLParser) shows the same structure inside
#content-inneron both:There is no
<h2>inside#content-inneron either localhost (HSG_ENV=production build) or the prod-preview3 Jenkins target. That's why 3.11.3's Jenkins run failed — the new pin had nothing to match.The original p2 Jenkins failure that motivated #598 was a cold-cache timing flake, already mitigated by the
waitForExistwrapper added in 33b5890. Thelevel: 'h3'was the correct pin all along.Test plan
HSG_ENV=productionbuild + redeploy +wdio … --spec tests/specs/departmenthistory/prod_shorthistory_titles.spec.js→ 3 passing in 1.2s.hsg-prod-preview3rerun after merge — should also pass.🤖 Generated with Claude Code