Skip to content

Clarify .env files#1242

Merged
dawsontoth merged 2 commits into
stagefrom
STUDIO-361_clarify-env
Jun 12, 2026
Merged

Clarify .env files#1242
dawsontoth merged 2 commits into
stagefrom
STUDIO-361_clarify-env

Conversation

@dawsontoth

@dawsontoth dawsontoth commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

I shuffled several of the .env files used for deployments to be hidden in a sub-directory, and then I clarified on fabric vs local mode. I removed a few confusing package.json scripts by passing more flags in the GitHub actions too. All in all, it should be less confusing now, I hope. The .env.local becomes your single local environment file, nothing else is needed.

Aside from local verification and careful perusal of the changes, I also pushed this to dev successfully https://github.com/HarperFast/studio/actions/runs/27431497498

https://harperdb.atlassian.net/browse/STUDIO-361

@dawsontoth dawsontoth requested a review from a team as a code owner June 12, 2026 17:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the environment configuration by moving build-mode env files to .github/deploy-public-env and dynamically setting Vite's envDir based on the active mode. It also refactors the development and build scripts in package.json, the Makefile, and documentation to support this structure. Feedback highlights that setting envDir redirects Vite's search for .env.local to that directory, which should be documented in the configuration comments. Additionally, the inline environment variable definition in the dev:local script is not cross-platform and should use cross-env to support Windows environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread vite.config.ts
Comment thread package.json Outdated
@dawsontoth dawsontoth force-pushed the STUDIO-361_clarify-env branch from d7b4506 to bb044b4 Compare June 12, 2026 17:32

@cb1kenobi cb1kenobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dawsontoth dawsontoth enabled auto-merge June 12, 2026 19:54
@dawsontoth dawsontoth disabled auto-merge June 12, 2026 19:54
@dawsontoth dawsontoth merged commit 57de965 into stage Jun 12, 2026
2 checks passed
@dawsontoth dawsontoth deleted the STUDIO-361_clarify-env branch June 12, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants