Skip to content

fix: avoid stale versions in switch-instance popup #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 1 commit into from
May 27, 2026
Merged

fix: avoid stale versions in switch-instance popup #6133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/GameListPopupMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ public static void show(Node owner, JFXPopup.PopupVPosition vAlign, JFXPopup.Pop
double initOffsetX, double initOffsetY,
Profile profile, List<Version> versions) {
GameListPopupMenu menu = new GameListPopupMenu();
menu.getItems().setAll(versions.stream().map(it -> new GameItem(profile, it.getId())).toList());
menu.getItems().setAll(versions.stream()
.filter(it -> profile.getRepository().hasVersion(it.getId()))
.map(it -> new GameItem(profile, it.getId()))
.toList());
Comment thread
pynickle marked this conversation as resolved.
JFXPopup popup = new JFXPopup(menu);
popup.show(owner, vAlign, hAlign, initOffsetX, initOffsetY);
}
Expand Down