优化游戏列表 Popup 列表项大小#6119
Open
CiiLu wants to merge 2 commits into
Open
Conversation
Contributor
CiiLu
commented
May 17, 2026
之前单个项看起来比账户列表的单个项大很多
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the GameListPopupMenu cell layout, reducing the fixed cell size from 60 to 50 and replacing the HBox layout with a BorderPane structure. Feedback identifies that the refactoring introduced hitbox issues due to the combination of setPickOnBounds(false) and mouse-transparent children, and caused a loss of spacing and alignment between the icon and text. Furthermore, the reviewer suggests moving the width binding to the rootPane and replacing the magic number 50 with a constant to improve maintainability.
Member
|
这个有必要调整吗?现在是和游戏实例列表中一致的。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.