[Enhancement] 导出整合包-文件选择优化#6115
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the modpack file selection UI and filtering logic, introducing a directory-first sorting mechanism and hierarchical level tracking. However, several issues were identified: setting CheckBoxTreeItem values to empty strings breaks file path construction in the export logic, and the use of substringAfter for labels displays incorrect nested paths. Additionally, performing I/O operations like Files.isDirectory inside a comparator significantly impacts performance, and a redundant match method was introduced in the Modpack class that duplicates existing logic in ModAdviser.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the modpack file selection UI by introducing a custom ModpackFileTreeItem and enhancing the tree's filtering and sorting logic. It also standardizes path handling to use forward slashes for cross-platform consistency and moves matching logic into the Modpack class. Feedback suggests implementing case-insensitive sorting for the file tree to improve the user experience on Linux and optimizing regex matching in Modpack by pre-compiling patterns to avoid performance issues during large file processing.
…ectionPage.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
natives-os-arch文件夹Resolves #6073 Fixes #6116
顺带提一句,电磁炉在 #5367 中的修复是没有问题的,因为所谓“其他地方”都不会传入目录,不会被他的修改影响到。