[Feature] 模组等的更新日志以及 HTMLRenderer 的完善#6098
Conversation
# Conflicts: # HMCL/src/main/resources/assets/lang/I18N.properties # HMCL/src/main/resources/assets/lang/I18N_es.properties # HMCL/src/main/resources/assets/lang/I18N_ja.properties # HMCL/src/main/resources/assets/lang/I18N_lzh.properties # HMCL/src/main/resources/assets/lang/I18N_ru.properties # HMCL/src/main/resources/assets/lang/I18N_uk.properties # HMCL/src/main/resources/assets/lang/I18N_zh.properties # HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCLCore/build.gradle.kts
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCL/src/main/resources/assets/css/root.css
# Conflicts: # HMCL/src/main/resources/assets/about/deps.json
This reverts commit b62d8e3.
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/HTMLRenderer.java # HMCL/src/main/resources/assets/about/deps.json # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java # gradle/libs.versions.toml
# Conflicts: # HMCL/src/main/resources/assets/about/deps.json # HMCLCore/build.gradle.kts # gradle/libs.versions.toml
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonUpdatesPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/LocalModFile.java # HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a changelog viewing system for mods and addons, incorporating the CommonMark library for Markdown-to-HTML conversion and significantly upgrading the HTMLRenderer to support tables, code blocks, and asynchronous image loading. UI updates in AddonUpdatesPage and DownloadPage enable users to access changelogs and external version URLs. Feedback points out potential memory leaks in JavaFX property bindings to static controllers, code duplication across changelog dialog implementations, and the need for more robust error handling when generating repository URLs to prevent UI crashes.
| tableView.setFixedCellSize(25); | ||
| tableView.setPrefHeight(25 * (rows.size() + 1) + 5); |
There was a problem hiding this comment.
在渲染 HTML 表格时，使用固定的行高（setFixedCellSize(25)）会导致内容在多行文本或较大字体下被截断。建议移除固定行高。另外，在第 373 行和第 380 行创建单元格内容时，未调用 mergeLineBreaks()，这可能导致表格内部的换行符处理与外部不一致。建议在 render() 之前调用 mergeLineBreaks()。
There was a problem hiding this comment.
要不先这样吧。。。
修不好一点，子元素的高度明明只有15但父元素却有60，删掉固定行高会出问题
3 participants
添加了下载模组、数据包等以及更新模组时显示更新日志的功能
Resolves #4685
具体变化：
HTMLRenderer的优化与完善，以及对 Markdown 的支持（引入了新依赖）TODO：