configuration: decouple hardcoded colors into default.theme#4124
Conversation
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| Note that core color configurations have been abstracted away from the main template file. | ||
| The system defaults now reference an include directive mapping directly to default.theme. |
There was a problem hiding this comment.
Docs typically should not reference changes, but should just document how things are.
|
|
||
| # From the CMAKE value of the same name. This is substituted at configure. | ||
| CMAKE_BINARY_DIR = os.path.abspath("${CMAKE_BINARY_DIR}") | ||
| CMAKE_BINARY_DIR = os.path.abspath("/home/joe/Contributions/taskwarrior") |
There was a problem hiding this comment.
My mistake! Restored the original ${CMAKE_BINARY_DIR} template token
| hooks.on-exit.test.py | ||
| ) | ||
|
|
||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../doc/rc/default.theme default.theme COPYONLY) |
There was a problem hiding this comment.
I don't think this directive belongs here.
There was a problem hiding this comment.
Removed that code block from the CMakeLists.txt file
| home_dir = getenv("HOME"); | ||
|
|
||
| std::vector<std::string> searchPaths{TASK_RCDIR}; | ||
| std::vector<std::string> searchPaths{TASK_RCDIR, "doc/rc", "../doc/rc"}; |
There was a problem hiding this comment.
These paths won't exist in a built version of Taskwarrior.
There was a problem hiding this comment.
how do the tests check the file paths?
… integration tests
… integration tests
dud-eisme
force-pushed
the
feature/decouple-default-theme
branch
5 times, most recently
from
b33d909 to
082b6a6
Compare
… integration tests
dud-eisme
force-pushed
the
feature/decouple-default-theme
branch
from
082b6a6 to
e1babfb
Compare
|
All core theme and configuration parsing tests are passing 100% |
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
This looks good! Thank you!
I'm not sure why tests are failing with I/O errors.
djmitche
merged commit 76537e1
into
GothenburgBitFactory:develop
|
I guess it was a flake -- thank you for the contribution! |
…tFactory#4124) Signed-off-by: ashprice <gitcommit1@sl.ashprice.co.uk>
2 participants
Closes #3669 (Move color settings from taskrc to default.theme)
default.themein thedoc/rcdirectory.default.themeto the man page list in thetaskrc.5.infile.