fix(security_center): Rename region tag security_center_list_findings_within_time_range and move sample into security_command_center folder #10288
Open
Kef131 wants to merge 3 commits into
Open
fix(security_center): Rename region tag security_center_list_findings_within_time_range and move sample into security_command_center folder #10288Kef131 wants to merge 3 commits into
security_center_list_findings_within_time_range and move sample into security_command_center folder #10288Kef131 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the region tags in FindingSnippets.java to securitycenter_list_findings_within_time_range and removes an unused Maven project file. The reviewer points out that the method name listFindingsAtTime and its Javadoc should be updated to maintain consistency with the renamed region tag.
… Command Center management snippets
amcolin
requested changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # b/517939862
Updated the region tag from
securitycenter_list_findings_at_timetosecuritycenter_list_findings_within_time_rangeinFindingSnippets.java. Also Moved all snippets fromsecuritycenterintosecurity-command-center.security-command-centerfolder: When the tests attempted to iterate over lazy-loadedPagedResponse(used a try-with-resources block to create theSecurityCenterManagementClientclient), after the helper method had exited, the client was already closed and its internal executor was terminated, resulting in the RejectedExecutionException. Then modified the 7 helper list classes inmanagement/apito return anImmutableListof the results rather than the lazy-loadedPagedResponseobject.Extra info for reviewers and for history
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequired (Integration tests are skipped during compile using-DskipTestssince they require live organization credentials, but all main and test code compiles successfully)mvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only (Static analysis fails under JDK 25 environment due to ErrorProne plugin compatibility issues with jdk.compiler module exports)