feat: Dynamic Root Configuration Support#6
Conversation
- Modified `FactorioServerManager.ps1` to resolve and launch using `server-settings.json` and `server-adminlist.json` located at the script root instead of the volatile installation data directory. - Refactored `example_batch.bat` using delayed expansion to conditionally attach `--server-settings` and `--server-adminlist` arguments if those root configurations exist. - Overhauled `README.md` to introduce the "Configuration & Admin List" section to document the usage for the official release.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bedbc123d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $settings = Join-Path $scriptRoot 'server-settings.json' | ||
| if (!(Test-Path $settings) -and (Test-Path $template)) { | ||
| Copy-Item $template $settings |
There was a problem hiding this comment.
When an existing user upgrades, their customized settings are still at Factorio\data\server-settings.json, but this path now only checks for a root server-settings.json and then copies the example template. The next launch will therefore ignore the user's existing server name/password/visibility settings and start with a fresh default config instead of the previously managed one; please migrate or fall back to the old file before creating a template-based root file.
Useful? React with 👍 / 👎.
1 participant
Moved server settings and admin list management to the repository root for both the PowerShell GUI script and the alternative batch file. This prevents users from losing their configuration when the server binaries are purged or updated. Updated README to document these new behaviors.
PR created automatically by Jules for task 10284877200360802863 started by @GhostwheeI