Update scripts to dynamically load settings and adminlist from root#5
Update scripts to dynamically load settings and adminlist from root#5GhostwheeI wants to merge 1 commit into
Conversation
* Move settings target path to scriptRoot/BaseDir in ps1 and bat * Dynamically include --server-settings and --server-adminlist args * Update README.md to reflect the new dynamic loading behavior * Fix delayed expansion bug in batch script array concatenation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This commit addresses the issue of loading configuration files dynamically from the root directory instead of the volatile Factorio data folder. It enables loading both
server-settings.jsonandserver-adminlist.jsonautomatically if they exist in the root directory.Changes applied:
FactorioServerManager.ps1to useserver-settings.jsonandserver-adminlist.jsonfrom the root. Added dynamic argument generation forLaunch-Server.example_batch.batto include identical logic, loading settings from the root and appropriately handling delayed expansion to append variables securely within the parentheticalifstatements.README.mdto reflect these features.PR created automatically by Jules for task 2724403944361829531 started by @GhostwheeI