Move configuration files to repository root and add dynamic inclusion#10
Move configuration files to repository root and add dynamic inclusion#10GhostwheeI wants to merge 1 commit into
Conversation
- Moved expected location of `server-settings.json` to the repo root to prevent accidental overwrites during server binary updates. - Added support for `server-adminlist.json` at the repo root. - Updated `FactorioServerManager.ps1` and `example_batch.bat` to dynamically include these configuration files as launch arguments if they exist. - Updated `example_batch.bat` with `setlocal EnableDelayedExpansion` to ensure correct variable expansion inside `if` blocks. - Updated `README.md` to reflect the new configuration file locations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 066045fb8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function Ensure-SettingsFile { | ||
| $template = Join-Path $InstallDir 'data\server-settings.example.json' | ||
| $settings = Join-Path $InstallDir 'data\server-settings.json' | ||
| $settings = Join-Path $scriptRoot 'server-settings.json' |
There was a problem hiding this comment.
For users who already ran the previous version, option 3 wrote their customized credentials/password/visibility to Factorio\data\server-settings.json; after this path switch the script only checks the repo-root file. Because the repository already includes a root server-settings.json, Ensure-SettingsFile will not copy or migrate the existing data-directory settings, and launches will silently ignore the user's real server configuration. Please migrate or fall back to the old path when the new root file has not been explicitly created by the user; the batch script's SettingsFile path change has the same regression.
Useful? React with 👍 / 👎.
1 participant
Relocates server configuration files (
server-settings.jsonandserver-adminlist.json) from the Factorio binary directory to the repository root. This makes it safer for automated server updates. Both the PowerShell and batch scripts were updated to dynamically load these files on launch if present. Documentation has also been updated.PR created automatically by Jules for task 10712689773682947600 started by @GhostwheeI