LIBTRACK-134: Remove Google Sheets support#34
Draft
naarok wants to merge 4 commits into
Draft
Conversation
The gem used to populate a Google Sheet, but that output was replaced by the Library Tracking app and is already marked deprecated. Remove the gsheet path, its Google dependencies, and the dual-mode branching so Library Tracking is the single upload destination. - Remove `googleauth` / `google-api-client` gem dependencies and the `googleauth` / `google/apis/sheets_v4` requires. - Delete `update_spreadsheet()` and `spreadsheet_data()`. - Remove the `spreadsheet_id` mode branch in `go()`; always upload to Library Tracking. Drop the Sheets range constants and legacy source-name mapping. - BREAKING: remove the `spreadsheet_id` keyword from `CheckVersionStatus.run()` and the `exe/analyze` CLI; drop the `VERSION_STATUS_SPREADSHEET_ID` read from `Analyze.go`. - README: remove the deprecated Google keys / Version Status spreadsheet sections. Coordinated with JOB-171738 (Jobber stops passing `spreadsheet_id`). Initializes OpenSpec in this repo and adds the `remove-gsheet-support` change (proposal, design, specs, tasks). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Amplify 2.0.0 <amplify@getjobber.com>
Removing the googleauth / google-api-client gems also removed the transitive `require`s that several files were unknowingly relying on for Ruby stdlib. Without the Google gems loaded, the suite failed with `uninitialized constant Open3` and `undefined method 'parse' for Time`. Make each file require the stdlib it actually uses: - npm.rb, pnpm.rb, gemfile.rb: `open3` (and `json` for npm/pnpm) - github.rb: `date`, `time` - library_tracking.rb: `uri`, `zlib` Full suite now passes (109 examples, 0 failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Amplify 2.0.0 <amplify@getjobber.com>
`multi_json` was declared in the Gemfile solely so that `representable` (pulled in via google-api-client) could load `google/apis/sheets_v4` in CI. This change removes google-api-client and all Google Sheets usage, so multi_json is no longer needed by anything. Full suite passes without it (116 examples, 0 failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Amplify 2.0.0 <amplify@getjobber.com>
naarok
force-pushed
the
libtrack-134-remove-support-for-sheet
branch
from
ab4cd4d to
02c03ed
Compare
Promote the library-version-upload capability into openspec/specs and move the completed change to openspec/changes/archive/2026-06-10-*. Bundled into this PR so no separate archive-only PR is needed after merge. Co-Authored-By: Amplify 2.1.1 <amplify@getjobber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The gem used to populate a Google Sheet, but that output was replaced by the Library Tracking app and is already marked deprecated. This removes the gsheet path entirely so Library Tracking is the single upload destination.
Jira: LIBTRACK-134
Changes
googleauth/google-api-clientgem dependencies and thegoogleauth/google/apis/sheets_v4requires.update_spreadsheet()andspreadsheet_data().spreadsheet_idmode branch ingo(); always upload to Library Tracking. Drop the Sheets range constants and legacy source-name mapping.spreadsheet_idkeyword fromCheckVersionStatus.run()and theexe/analyzeCLI; drop theVERSION_STATUS_SPREADSHEET_IDread fromAnalyze.go.remove-gsheet-supportchange (proposal, design, specs, tasks).Coordination
Paired with JOB-171738 (Jobber stops passing
spreadsheet_id). Because removing the parameter is breaking, the Jobber PR should merge first or together with this one.Testing
CheckVersionStatusspecs pass (7/7);bundle installresolves cleanly without the Google gems.uninitialized constant Open3errors in the npm/pnpm specs, unrelated to this change.Out of scope
Decommissioning the Google service account / sheet and the untracked local credential scripts (
version_prod.sh, etc.).Co-Authored-By: Amplify 2.0.0 amplify@getjobber.com