Skip to content

[Fixes #14437] Fixes keywords lost on style updates#14438

Open
sijandh35 wants to merge 1 commit into
masterfrom
ISSUE_14437
Open

[Fixes #14437] Fixes keywords lost on style updates#14438
sijandh35 wants to merge 1 commit into
masterfrom
ISSUE_14437

Conversation

@sijandh35

Copy link
Copy Markdown
Contributor

Fixes #14437

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GeoServer keyword synchronization logic to merge incoming keywords with existing ones instead of replacing them. It introduces a --skip-keywords option to the updatelayers command and adds a new importgskeywords parameter to control when keywords are imported. Additionally, corresponding unit tests have been added to verify the merging behavior. The feedback suggests adding a fallback empty list when converting instance.keyword_list() to a set to prevent potential TypeError exceptions if it returns None.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/geoserver/helpers.py
@sijandh35 sijandh35 requested review from etj and giohappy July 14, 2026 09:54
@sijandh35 sijandh35 assigned etj and sijandh35 and unassigned sijandh35 Jul 14, 2026
@sijandh35 sijandh35 requested a review from mattiagiupponi July 14, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keywords lost on style updates

2 participants