[Fixes #14437] Fixes keywords lost on style updates#14438
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the GeoServer keyword synchronization logic to merge incoming keywords with existing ones instead of replacing them. It introduces a --skip-keywords option to the updatelayers command and adds a new importgskeywords parameter to control when keywords are imported. Additionally, corresponding unit tests have been added to verify the merging behavior. The feedback suggests adding a fallback empty list when converting instance.keyword_list() to a set to prevent potential TypeError exceptions if it returns None.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Fixes #14437
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.