Skip to content

[Fixes #14177] Implement storage and handling of authentications for external resources#14192

Merged
giohappy merged 7 commits into
masterfrom
ISSUE_14177
May 12, 2026
Merged

[Fixes #14177] Implement storage and handling of authentications for external resources#14192
giohappy merged 7 commits into
masterfrom
ISSUE_14177

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14177

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 4, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 79.41953% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.64%. Comparing base (0343f6f) to head (b571fed).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14192      +/-   ##
==========================================
+ Coverage   64.87%   74.64%   +9.77%     
==========================================
  Files         960      967       +7     
  Lines       58866    59164     +298     
  Branches     8070     8051      -19     
==========================================
+ Hits        38188    44165    +5977     
+ Misses      19054    13194    -5860     
- Partials     1624     1805     +181     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sijandh35 sijandh35 marked this pull request as draft May 4, 2026 16:07
@sijandh35 sijandh35 marked this pull request as ready for review May 4, 2026 16:14
@sijandh35 sijandh35 requested a review from Gpetrak May 5, 2026 05:56
@sijandh35 sijandh35 assigned sijandh35 and unassigned sijandh35 May 5, 2026
Comment thread geonode/services/utils.py Outdated
@sijandh35 sijandh35 requested a review from giohappy May 5, 2026 11:03
Comment thread geonode/security/admin.py Outdated
Comment thread geonode/security/admin.py Outdated
Comment thread geonode/security/auth_registry.py Outdated
Comment thread geonode/security/utils.py Outdated
Comment thread geonode/security/utils.py Outdated
Comment thread geonode/services/serviceprocessors/wms.py Outdated
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 7, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sijandh35 sijandh35 requested a review from giohappy May 7, 2026 14:41
Comment thread geonode/services/serviceprocessors/wms.py Outdated
Comment thread geonode/services/forms.py Outdated
Comment thread geonode/thumbs/thumbnails.py
@sijandh35 sijandh35 requested a review from giohappy May 8, 2026 11:42
@giohappy giohappy merged commit 41ea655 into master May 12, 2026
17 checks passed
@giohappy giohappy deleted the ISSUE_14177 branch May 12, 2026 14:29
giohappy pushed a commit that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement storage and handling of authentications for external resources

3 participants