fix(collection-seeding): seed placeholder collections to fix CI collection IDs#1277
Open
fhennig wants to merge 2 commits into
Open
fix(collection-seeding): seed placeholder collections to fix CI collection IDs#1277fhennig wants to merge 2 commits into
fhennig wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…CI collection IDs COVID resistance mutation collections are hardcoded as IDs 4, 5, 6 in wastewaterConfig.ts, but on a fresh DB the seeder assigned them 1, 2, 3. Seeding 3 placeholder collections first reserves those IDs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On fresh DBs, the IDs for the covid resistance mutations are not right, they'd be 1, 2, 3, but on staging and prod they are 4, 5, 6. This causes issues when running E2E tests in CI:
We can't change the staging IDs now, and we don't want to introduce yet another switch for different IDs when deploying locally to a fresh, empty DB. My idea is thus, to simply cause the same offset as we have on staging, by inserting placeholder collections.
It's a bit stupid, but it works.
Alternatively, I guess we could wipe the staging DB once, and adjust the IDs in the config accordingly. Maybe that's the better option, actually.
Summary
wastewaterConfig.tsPlaceholderSourcethat seeds 3 dummy collections first, reserving IDs 1–3 so COVID resistance mutations land on 4, 5, 6 as expectedTest plan
🤖 Generated with Claude Code