Add 'get_all' request to handle paging. Add retries. Get all emails of person.#32
Open
maaikez wants to merge 3 commits into
Open
Add 'get_all' request to handle paging. Add retries. Get all emails of person.#32maaikez wants to merge 3 commits into
maaikez wants to merge 3 commits into
Conversation
Arkaikus
suggested changes
Dec 22, 2021
Arkaikus
left a comment
Arkaikus
left a comment
There was a problem hiding this comment.
client._parse method is returning bytes instead of dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New get_all function to handle paging and get all the records.
Add retries and interval between retries.
Request to get all emails of a person.
Change parse function so _request function can also be used to download files. Did not add the file download function yet.