perf(web-ui): defer inactive session metadata startup#1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show less, so older perf fixtures remain reachable in multi-workspace nav state.Refs #949
Performance data
Environment: Windows desktop
release-fastperformance E2E on the same local workspace. Current-PR before sample is the pre-change run ongcwing/main/this branch base; after samples are the latest three current-commit release-fast runs.interactive_shell_readylist_persisted_sessions_pagecallsLarge-session opening is kept as a regression guard in this PR, not claimed as the main optimization target because the product change is startup metadata scheduling. Latest current-commit guard results:
Risk and behavior impact
data-session-nav-toggle-actionattribute is test-only metadata on the existing show-more button and does not change the user-visible control.Verification
pnpm --dir src/web-ui run test:run src/app/startup/startupPerformanceContract.test.ts src/app/components/NavPanel/sections/sessions/sessionMetadataStartup.test.tspnpm run type-check:webpnpm run check:repo-hygienepnpm run desktop:build:release-fastpnpm run e2e:test:perf:release-fast