refactor(core): organize crates into six ownership layers#1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cratesinto six ownership layers:interfaces,assembly,adapters,services,execution, andcontracts.tool-contracts,tool-provider-groups, andtool-executionwhile keeping Cargo package/lib names stable for compatibility.Impact and Risk
src/crates/<layer>/<crate>so layered paths do not collapse into one crate risk area.facade,integrations,product,surfaces, and ambiguous execution tool folder paths are removed from active workspace paths.Verification
git fetch gcwing main && git rebase gcwing/maingit grep -n -E "src/crates/(facade|integrations|product|providers|surfaces)|crates/(facade|integrations|product|providers|surfaces)|src\\crates\\(facade|integrations|product|providers|surfaces)" HEAD -- Cargo.toml src/apps src/crates scripts src/web-ui docs AGENTS.md AGENTS-CN.md README.md README.zh-CN.md CONTRIBUTING.md CONTRIBUTING_CN.mdgit diff --check gcwing/main..HEADcargo metadata --no-deps --format-version 1node --test scripts/check-core-boundaries.test.mjsnode scripts/check-core-boundaries.mjspnpm --dir src/web-ui run test:run src/shared/services/reviewTargetClassifier.test.ts src/shared/services/review-team/pathMetadata.test.ts src/shared/services/review-team/risk.test.ts src/shared/services/reviewTeamService.test.tspnpm run check:repo-hygienepnpm run i18n:contract:testcargo check -p bitfun-core --no-default-featurescargo check -p bitfun-core --features product-fullcargo check --workspacecargo test -p bitfun-agent-toolscargo test -p tool-runtimecargo test -p bitfun-tool-packs --features product-fullcargo test -p bitfun-product-domains --no-default-featurescargo test -p bitfun-product-capabilities