Add: vCard Version selection for export #344#439
Add: vCard Version selection for export #344#439jguegel wants to merge 5 commits intoFossifyOrg:mainfrom
Conversation
|
note:
please be patient, just trying to help the community, if too much is wrong just close the PR |
|
@Tchiller thanks for the feedback, bundling into a new object out has been a good idea. will have a look into it |
# Conflicts: # CHANGELOG.md
|
@Tchiller please check again, i decided to split up in multiple files to avoid lint complaints |
|
Hey @jguegel — went through the post-March state in detail. Most of it's fine, but a few concerns plus one structural one (the |
| when { | ||
| contactsExported == 0 -> EXPORT_FAIL | ||
| contactsExported == 0 -> ExportResult.EXPORT_FAIL | ||
| contactsFailed > 0 -> ExportResult.EXPORT_PARTIAL |
There was a problem hiding this comment.
@naveensingh Quick question on existing behavior: contactsFailed is never incremented (was the case before this PR too), so EXPORT_PARTIAL looks unreachable. Since this code is being reorganized here anyway, it'd be a natural moment to either revive it via per-contact try/catch or drop the partial state entirely. Any preference? Happy to handle in a follow-up PR if you'd rather keep this one focused.
Type of change(s)
What changed and why
Tests performed
Before & after preview
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).