fix(datasource-zendesk): coerce id filter values to integers for PK lookups

[christophebrun-forest]

Problem

The agent parses Number values through to_f, so id = N / id IN [...] filters reach the Zendesk datasource as floats (e.g. 123.0). The PK-lookup short-circuit (extract_id_lookup) forwarded those straight to Zendesk's REST endpoints:

• GET /tickets/show_many?ids=123.0 is rejected by Zendesk. Its error body embeds a validation regex whose backslashes are invalid JSON, so parsing the response also throws — surfacing as:

  APIError: Zendesk API call failed: fetch_tickets_by_ids:
  JSON::ParserError: invalid escape character in string:
  '\A\s*(?:(?:\d+|suspended|deleted' ...
  

• Even when a call succeeds, the id-keyed result map ({ 123 => ticket }) is looked up with a float key (123.0) → miss → records silently dropped.

This was hit in real conditions by the workflow fallback-inbox flow, which lists client records via id IN [recordId].

Fix

Normalise id values to Integer in extract_id_lookup — the single choke point shared by Ticket (fetch_tickets_by_ids) and User/Organization (find_one) — before any REST call. Handles float and numeric-string inputs, leaves non-coercible values untouched.

Why existing tests missed it

The specs built condition trees with raw integers (Leaf.new('id', 'in', [1, 2])), bypassing the agent parser and its to_f casting. Added regression specs that pass float ids through the datasource for both the Ticket IN/EQUAL paths and the User find_one path.

Validation

• 245 examples, 0 failures (full Zendesk datasource suite), coverage 99.33%
• RuboCop clean
• Confirmed against the real production stack trace

Scope note

The underlying to_f cast for Number columns lives in the shared agent parser (condition_tree_parser.rb) and affects all datasources; this PR fixes it locally where it breaks Zendesk. A broader look at the parser's numeric coercion for primary keys is worth a separate ticket.

🤖 Generated with Claude Code

Note

Coerce id filter values to integers in Zendesk datasource PK lookups

Adds a normalize_id helper to BaseCollection that converts values like 1.0 or "1" to integers using Integer(value, exception: false), falling back to the original value on failure. The extract_id_lookup method now applies this normalization for both EQUAL and IN id filters before passing ids to Zendesk API calls.

^{Macroscope summarized a2eff83.}

[forest-bot]

🎉 This PR is included in version 1.35.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀