Skip to content

Reject NaN Gaussian hypothesis log weights#2676

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-normalize-log-weights-nan
Open

Reject NaN Gaussian hypothesis log weights#2676
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-normalize-log-weights-nan

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Reject NaN values in normalize_log_weights instead of silently returning uniform weights.
  • Prevent moment_match_gaussian_hypotheses from assigning posterior mass to hypotheses with invalid NaN log weights.
  • Add regression coverage for direct normalization and Gaussian hypothesis moment matching.

Bug

normalize_log_weights previously let np.max([0.0, np.nan]) become NaN, then treated the non-finite maximum as a degenerate all-zero case and returned uniform weights. This silently gave invalid hypotheses nonzero posterior mass.

Testing

  • Not run locally; this environment cannot clone or execute the GitHub repository because outbound DNS resolution to GitHub is unavailable. The change is covered by a targeted regression test in tests/filters/test_gaussian_hypothesis_mixture.py.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 14, 2026 08:09
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 52.67s
✅ JSON prettier 7 0 0 0 1.09s
✅ JSON v8r 7 0 0 5.41s
✅ MARKDOWN markdownlint 68 0 0 0 2.0s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.8s
✅ PYTHON black 871 1 0 0 51.18s
✅ PYTHON isort 871 2 0 0 3.1s
✅ REPOSITORY checkov yes no no 49.63s
✅ REPOSITORY gitleaks yes no no 11.35s
✅ REPOSITORY git_diff yes no no 0.07s
✅ REPOSITORY secretlint yes no no 26.81s
✅ REPOSITORY syft yes no no 4.91s
✅ REPOSITORY trivy-sbom yes no no 6.79s
✅ REPOSITORY trufflehog yes no no 24.7s
✅ YAML prettier 11 0 0 0 0.81s
✅ YAML v8r 11 0 0 11.62s
✅ YAML yamllint 11 0 0 0.6s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant