Skip to content

Respect predict_proba class ordering in association wrapper#2673

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-imm-infinite-log-likelihoods
Jun 13, 2026
Merged

Respect predict_proba class ordering in association wrapper#2673
FlorianPfaff merged 2 commits into
mainfrom
fix-imm-infinite-log-likelihoods

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Fix CalibratedPairwiseAssociationModel so binary predict_proba outputs use the column corresponding to class label 1 when the wrapped model exposes classes_.
  • Keep the existing fallback to column 1 for models without class metadata.
  • Add a regression test with reversed class order [1, 0] to prevent inverted match probabilities.

Notes

  • I initially inspected the IMM likelihood-update path as well, but this PR keeps the submitted change narrowly scoped to the association-wrapper bug that could be fixed safely through the connector.

Testing

  • Not run locally; sandbox could not clone GitHub due DNS resolution failure.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 13, 2026 20:55
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 54.36s
✅ JSON prettier 7 0 0 0 1.01s
✅ JSON v8r 7 0 0 5.91s
✅ MARKDOWN markdownlint 68 0 0 0 1.89s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.87s
✅ PYTHON black 870 1 0 0 41.77s
✅ PYTHON isort 870 2 0 0 5.52s
✅ REPOSITORY checkov yes no no 43.82s
✅ REPOSITORY gitleaks yes no no 10.92s
✅ REPOSITORY git_diff yes no no 0.13s
✅ REPOSITORY secretlint yes no no 23.7s
✅ REPOSITORY syft yes no no 3.51s
✅ REPOSITORY trivy-sbom yes no no 5.53s
✅ REPOSITORY trufflehog yes no no 23.67s
✅ YAML prettier 11 0 0 0 0.74s
✅ YAML v8r 11 0 0 10.99s
✅ YAML yamllint 11 0 0 0.66s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 1b26a3b into main Jun 13, 2026
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant