Fixed: OMC parse error (Expected RBRACE, got 'formate')#85
Open
shubham148-st wants to merge 1 commit into
Open
Fixed: OMC parse error (Expected RBRACE, got 'formate')#85shubham148-st wants to merge 1 commit into
shubham148-st wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a critical OpenModelica (OMC) parsing error (
Expected RBRACE) that occurred when simulating chemical compounds containing spaces, hyphens, or special characters. It enforces strict Modelica identifier compatibility by ensuring that all compound names are normalized into valid, single-word identifiers before being passed to the simulation engine.Changes
_normalize_compound_nameutility function which was previously defined(Flowsheet.py ln 10-24) but was unused into the flowsheet generation logic. This function ensures that any multi-word or special-character compound name (e.g.,'Hydrogen cyanide','Carbon-tetrachloride') is programmatically transformed into a valid Modelica identifier (e.g.,'Hydrogencyanide','Carbontetrachloride') before compilation.strip('[').strip(']')) inUnitOperations.pywith the_normalize_compound_namefunction. This prevents structural corruption of the string when handling lists of compounds.