Fix review audit and lint findings

[chubes4]

Summary

• Fixes PHPCS findings surfaced by homeboy CI probe run 28747327863, including short ternary expansion and narrow prepared-SQL handling for code-defined identifiers.
• Replaces audit-reported option/group slug literals with backing constants where safe.
• Updates tests to use existing option/group constants instead of duplicating backing values.

Verification

• homeboy review lint data-machine --path /Users/chubes/Developer/data-machine@fix-review-findings --changed-since origin/main --lab-only --runner homeboy-lab passed with no findings on run 9cfea0a4-945f-4518-9cef-4a50f06893dd.
• homeboy review audit data-machine --path /Users/chubes/Developer/data-machine@fix-review-findings --only constant_backed_slug_literal --lab-only --runner homeboy-lab still reports whole-tree findings because audit --changed-since is not Lab-portable in the current Homeboy runner.
• homeboy review test data-machine --lab-only --runner homeboy-lab fails on existing broader runner/runtime failures: missing InMemoryConversationStore test class and CliCommandIntrospectorTest failures.

Surfaced by run 28747327863.

AI assistance

• AI assistance: Yes
• Tool(s): opencode general subagent (GPT-5.5), orchestrated by Franklin (Claude claude-fable-5)
• Used for: Fixed audit/lint findings surfaced by the homeboy review CI probe; Chris reviews and owns the change.

[homeboy-ci]

Homeboy Results — data-machine

Lint

✅ review lint — passed

ℹ️ Full options: homeboy self docs commands/lint
Deep dive: homeboy review lint data-machine --changed-since 7608522

Artifacts and drill-down

• CI results artifact: homeboy-ci-results-data-machine-review-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
• Observation artifact: homeboy-observations-data-machine-review-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
• Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
• Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/28760079356

Test

❌ review test — failed

ℹ️ No tests ran — the runner failed before producing results. See raw_output.stderr_tail / raw_output.stdout_tail for the underlying error (bootstrap failure, missing deps, DB connection, etc.).
ℹ️ To run specific tests: homeboy test data-machine -- --filter=TestName
ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Analyze failures: homeboy test data-machine --analyze
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy self docs commands/test
Deep dive: homeboy review test data-machine --changed-since 7608522

Artifacts and drill-down

• CI results artifact: homeboy-ci-results-data-machine-review-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
• Observation artifact: homeboy-observations-data-machine-review-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
• Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
• Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/28760079356

Audit

✅ review audit — passed

• audit — 117 finding(s)
• Total: 117 finding(s)

Deep dive: homeboy review audit data-machine --changed-since 7608522

Artifacts and drill-down

• CI results artifact: homeboy-ci-results-data-machine-review-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
• Observation artifact: homeboy-observations-data-machine-review-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
• Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
• Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/28760079356

Tooling versions

• Homeboy CLI: homeboy 0.281.12+9f8643f167a0+bd3a014a
• Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
• Extension revision: 68d84557
• Action: unknown@unknown