fix: serialize ECS task definition with Pulumi outputs#237
Open
droguljic wants to merge 1 commit into
Open
Conversation
Expose `taskDefinition` directly without wrapping in the `pulumi.Output` and use `pulumi.jsonStringify` for ECS `containerDefinitions`, so nested Pulumi Input and Output values resolve correctly during serialization. This prevents container definitions contain the unresolved Input and Output values and preserves the task definition when registration behavior preview values are unknown. Introduce unit tests for ECS service with task definition serialization test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
taskDefinitiondirectly without wrapping in thepulumi.Outputand usepulumi.jsonStringifyfor ECScontainerDefinitions, so nested Pulumi Input and Output values resolve correctly during serialization.This prevents container definitions contain the unresolved Input and Output values and preserves the task definition when registration behavior when preview values are unknown.
Introduce unit tests for ECS service with task definition serialization test cases.