Add Norwegian Nynorsk (nn) language#236
Open
arvindfroi wants to merge 2 commits into
Open
Conversation
Owner
|
Thank you. I'll look at this in the next few weeks.
|
prisis
pushed a commit
to visulima/visulima
that referenced
this pull request
Jun 19, 2026
Ports EvanHahn/HumanizeDuration.js#236 by adding a Norwegian Nynorsk (`nn`) duration language alongside the existing Norwegian Bokmål (`no`). - Add `src/language/nn.ts` with Nynorsk unit forms (månad/månader, veke/veker, dag/dagar, time/timar) and neuter plurals left unchanged per the official norm (minutt, sekund, millisekund). - Add `__fixtures__/duration/nn.tsv` test fixture (34 cases). - Register `nn` in the localized duration test and bump the assertion count accordingly. - Relabel "Norwegian" as "Norwegian Bokmål" and add "Norwegian Nynorsk" to the README language table. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AJpAwteq55WffChweDCept
prisis
pushed a commit
to visulima/visulima
that referenced
this pull request
Jun 19, 2026
Ports EvanHahn/HumanizeDuration.js#236 by adding a Norwegian Nynorsk (`nn`) duration language alongside the existing Norwegian Bokmål (`no`). - Add `src/language/nn.ts` with Nynorsk unit forms (månad/månader, veke/veker, dag/dagar, time/timar) and neuter plurals left unchanged per the official norm (minutt, sekund, millisekund). - Add `__fixtures__/duration/nn.tsv` test fixture (34 cases). - Register `nn` in the localized duration test and bump the assertion count accordingly. - Relabel "Norwegian" as "Norwegian Bokmål" and add "Norwegian Nynorsk" to the README language table. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AJpAwteq55WffChweDCept
prisis
added a commit
to visulima/visulima
that referenced
this pull request
Jun 19, 2026
Ports EvanHahn/HumanizeDuration.js#236 by adding a Norwegian Nynorsk (`nn`) duration language alongside the existing Norwegian Bokmål (`no`). - Add `src/language/nn.ts` with Nynorsk unit forms (månad/månader, veke/veker, dag/dagar, time/timar) and neuter plurals left unchanged per the official norm (minutt, sekund, millisekund). - Add `__fixtures__/duration/nn.tsv` test fixture (34 cases). - Register `nn` in the localized duration test and bump the assertion count accordingly. - Relabel "Norwegian" as "Norwegian Bokmål" and add "Norwegian Nynorsk" to the README language table. Claude-Session: https://claude.ai/code/session_01AJpAwteq55WffChweDCept Co-authored-by: Claude <noreply@anthropic.com>
prisis
pushed a commit
to visulima/visulima
that referenced
this pull request
Jun 19, 2026
…isulima/humanizer [3.0.0-alpha.15](https://github.com/visulima/visulima/compare/@visulima/humanizer@3.0.0-alpha.14...@visulima/humanizer@3.0.0-alpha.15) (2026-06-19) ### Features * **humanizer:** add Norwegian Nynorsk (nn) duration language ([#684](#684)) ([4d0c07d](4d0c07d)), closes [EvanHahn/HumanizeDuration.js#236](EvanHahn/HumanizeDuration.js#236)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Norwegian Nynorsk (
nn) as a supported language. The library already shipsno(Bokmål); Norway has two official written standards, and Nynorsk differs in several time units (e.g. månad/månader, veke/veker, dagar, timar), so this is a genuine addition rather than a duplicate ofno.Changes
humanize-duration.js: newnndefinition (inserted alphabetically beforeno).test/definitions/nn.tsv: full test fixtures fornn(mirrorsno.tsv).README.md: added aNorwegian Nynorsk/nnrow to the languages table (and relabelled the existingnorow asNorwegian Bokmålfor clarity) plus a credit line.Verification
Ran the actual humanizer against all 34
nn.tsvcases locally — all pass.getSupportedLanguages()now includesnnand still matches the set of.tsvfixtures (so the get-supported-languages test stays green).Disclosure
Prepared with AI assistance (Claude) and reviewed by a native Norwegian speaker (whose strongest dialect is Bokmål). The Nynorsk neuter plurals (minutt, sekund, millisekund unchanged) follow the official norm — happy to adjust if you'd prefer the -er variants.