Skip to content

update#1161

Open
xuhuanzy wants to merge 1 commit into
EmmyLuaLs:mainfrom
xuhuanzy:update
Open

update#1161
xuhuanzy wants to merge 1 commit into
EmmyLuaLs:mainfrom
xuhuanzy:update

Conversation

@xuhuanzy

Copy link
Copy Markdown
Member

No description provided.

github-actions[bot]

This comment was marked as low quality.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates infer_table_type_by_callee to use get_args() instead of children::<LuaAst>() when retrieving call arguments. This ensures that comments within call arguments do not shift the diagnostic ranges for missing fields. A corresponding unit test has been added to verify this behavior. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant