update#1150
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors generic type instantiation in instantiate_generic_type to prevent premature expansion of nested aliases (such as Promise<Unwrap<U>>) before their template parameters are fully inferred. It introduces a check to only recursively instantiate generic arguments when the current substitutor can resolve them, and preserves the alias form if template nodes remain. Several unit tests have been added to verify these changes and ensure correct type inference. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This reverts commit d7de3f5.
2 participants
No description provided.