Skip to content

Align YoutubeIngestor#discover_feed_url visibility with superclass#1312

Closed
Copilot wants to merge 24 commits into
masterfrom
copilot/fix-code-for-review-comment
Closed

Align YoutubeIngestor#discover_feed_url visibility with superclass#1312
Copilot wants to merge 24 commits into
masterfrom
copilot/fix-code-for-review-comment

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

Summary of changes

The linked review comment requested addressing only #discussion_r3287496889: discover_feed_url in YoutubeIngestor should not be part of the public ingestor API. This PR applies that scope exactly by making the method private to match MaterialRSSIngestor.

  • Visibility consistency
    • Added private in Ingestors::YoutubeIngestor before discover_feed_url.
    • No behavioral or logic changes beyond method visibility.
class YoutubeIngestor < MaterialRSSIngestor
  # ...

  private

  def discover_feed_url(content, base_url)
    # ...
  end
end

Motivation and context

Review feedback on PR #1276 identified a visibility mismatch between subclass and superclass for the same hook method; this change resolves that mismatch with minimal surface-area impact.

Screenshots

N/A (no UI change)

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree to license it to the TeSS codebase under the BSD license.

eilmiv and others added 23 commits May 22, 2026 09:53
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
…gestor

Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code according to review comment Align YoutubeIngestor#discover_feed_url visibility with superclass May 22, 2026
Copilot AI requested a review from eilmiv May 22, 2026 09:55
Copilot finished work on behalf of eilmiv May 22, 2026 09:55
@eilmiv eilmiv closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants