Align YoutubeIngestor#discover_feed_url visibility with superclass#1312
Closed
Copilot wants to merge 24 commits into
Closed
Align YoutubeIngestor#discover_feed_url visibility with superclass#1312Copilot wants to merge 24 commits into
YoutubeIngestor#discover_feed_url visibility with superclass#1312Copilot wants to merge 24 commits into
Conversation
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
…gestor Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ElixirTeSS/TeSS/sessions/3f53cf97-ee7d-4487-a164-02fdcba1b193 Co-authored-by: eilmiv <20646475+eilmiv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code according to review comment
Align May 22, 2026
YoutubeIngestor#discover_feed_url visibility with superclass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The linked review comment requested addressing only
#discussion_r3287496889:discover_feed_urlinYoutubeIngestorshould not be part of the public ingestor API. This PR applies that scope exactly by making the method private to matchMaterialRSSIngestor.privateinIngestors::YoutubeIngestorbeforediscover_feed_url.Motivation and context
Review feedback on PR #1276 identified a visibility mismatch between subclass and superclass for the same hook method; this change resolves that mismatch with minimal surface-area impact.
Screenshots
N/A (no UI change)
Checklist