Skip to content

py: add pyln-grpc-proto to PyPI publishing CI#8999

Open
ThomsenDrake wants to merge 1 commit into
ElementsProject:masterfrom
ThomsenDrake:feat/pyln-grpc-proto-publish-ci
Open

py: add pyln-grpc-proto to PyPI publishing CI#8999
ThomsenDrake wants to merge 1 commit into
ElementsProject:masterfrom
ThomsenDrake:feat/pyln-grpc-proto-publish-ci

Conversation

@ThomsenDrake
Copy link
Copy Markdown

@ThomsenDrake ThomsenDrake commented Mar 28, 2026

Summary\n\nFixes #7929 — Add pyln-grpc-proto to the PyPI publishing workflow so the package is automatically published on release.\n\nChangelog-None\n\n### Changes\n\n1. .github/workflows/pypi.yml — Added pyln-grpc-proto to the publish matrix (same pattern as pyln-client, pyln-proto, pyln-testing)\n\n2. Makefile — Added a dedicated update-pyln-grpc-version target that handles the versioning differences:\n - Directory layout: pyln/grpc/ instead of pyln/grpc-proto/\n - Version format: PyPI uses 25.09 (no v prefix), while the tag is v25.09\n\n3. contrib/pyln-grpc-proto/pyln/grpc/__init__.py — Synced stale __version__ from "0.1.1" to "25.09" to match pyproject.toml\n\n### Why a custom Makefile target?\n\nThe existing update-pyln-version-% pattern assumes:\n- Directory layout: contrib/pyln-<name>/pyln/<name>/__init__.py\n- Version passed verbatim from git describe\n\npyln-grpc-proto breaks both assumptions:\n- Uses contrib/pyln-grpc-proto/pyln/grpc/__init__.py\n- Needs the v prefix stripped for PyPI\n\nThe custom target is the minimal approach — it follows the exact same `` pattern as the generic targets and integrates into update-pyln-versions as a dependency.

…7929)

Add pyln-grpc-proto to the pypi.yml publish matrix and create a
dedicated update-pyln-grpc-version Makefile target that handles the
package's non-standard directory layout (pyln/grpc/ instead of
pyln/grpc-proto/) and strips the v-prefix from version tags.

Also syncs the stale __version__ in pyln/grpc/__init__.py to match
pyproject.toml.

Changelog-None
@ThomsenDrake ThomsenDrake force-pushed the feat/pyln-grpc-proto-publish-ci branch from 9349bed to 6f54133 Compare March 30, 2026 19:32
@madelinevibes madelinevibes linked an issue May 4, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BOUNTY! 🫰 A bounty is available for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

py: Add CI job to publish pyln-grpc-proto package to PyPI

2 participants