Skip to content

Adding 2 new mdi icons#1129

Merged
asodhi-eightfold merged 1 commit into
mainfrom
asodhi/add-octuple-icons
May 27, 2026
Merged

Adding 2 new mdi icons#1129
asodhi-eightfold merged 1 commit into
mainfrom
asodhi/add-octuple-icons

Conversation

@asodhi-eightfold
Copy link
Copy Markdown
Contributor

SUMMARY:

Adds two Material Design Icons to the IconName enum in src/components/Icon/mdi.ts: mdiArrowDecisionOutline (SVG · Pictogrammers) and mdiCreation (SVG · Pictogrammers). Both are cherry-picked from the upstream Templarian/MaterialDesign-JS reference noted at the top of the file. Entries are added as camelCase enum members in alphabetical order — mdiArrowDecisionOutline between mdiArrowCollapseUp and mdiArrowDown, and mdiCreation between mdiCopilotIconSmall and mdiCurrencyUsd. No other files changed.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-194454

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Just added two new icons, no new tests required as such

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.36%. Comparing base (b636943) to head (22cf656).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files        1230     1230           
  Lines       21425    21425           
  Branches     8129     8129           
=======================================
  Hits        18076    18076           
  Misses       3262     3262           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asodhi-eightfold
Copy link
Copy Markdown
Contributor Author

:shipit:

@asodhi-eightfold asodhi-eightfold merged commit 32bbef2 into main May 27, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants