Skip to content

Revert: dropdown and slider changes#1128

Merged
ychhabra-eightfold merged 2 commits into
mainfrom
yash/revert/sliderDropdown
May 15, 2026
Merged

Revert: dropdown and slider changes#1128
ychhabra-eightfold merged 2 commits into
mainfrom
yash/revert/sliderDropdown

Conversation

@ychhabra-eightfold
Copy link
Copy Markdown
Collaborator

SUMMARY:

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ychhabra-eightfold ychhabra-eightfold merged commit 12ac0f8 into main May 15, 2026
4 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.36%. Comparing base (731e16a) to head (0eb8461).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Dropdown/Dropdown.tsx 85.71% 1 Missing ⚠️
src/components/List/List.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files        1230     1230           
  Lines       21458    21425   -33     
  Branches     8148     8129   -19     
=======================================
- Hits        18103    18076   -27     
+ Misses       3268     3262    -6     
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant