Skip to content

Convert to npm#43

Open
peachbits wants to merge 2 commits into
masterfrom
convert-to-npm
Open

Convert to npm#43
peachbits wants to merge 2 commits into
masterfrom
convert-to-npm

Conversation

@peachbits
Copy link
Copy Markdown

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Identified one net-new security finding after module triage and deduplication.

Open in Web View Automation 

Sent by Cursor Security Agent: Security Reviewer

Comment thread AirshipDemo/README.md
This app shows off the react-native-airship built-in components.

To launch the demo, first run `yarn install` in this folder to set up the dependencies, and then run either `yarn android` or `yarn ios`.
To launch the demo, first run `npm install` in this folder to set up the dependencies, and then run either `npm run android` or `npm run ios`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Agentic Security Review
Severity: MEDIUM

This migration removes prior install-script hardening (.yarnrc with --ignore-scripts true) while directing users to run npm install, which executes lifecycle scripts by default.

Impact: A compromised dependency with install hooks could run arbitrary commands during install on developer/CI environments, increasing supply-chain execution risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant