Skip to content

[Node] fix process bot restart issues#3513

Merged
GuillaumeDSM merged 1 commit into
devfrom
restart
Jun 26, 2026
Merged

[Node] fix process bot restart issues#3513
GuillaumeDSM merged 1 commit into
devfrom
restart

Conversation

@GuillaumeDSM

Copy link
Copy Markdown
Member

there was 2 issues:

  1. we need to handle process octobot restarts (ex: when changing config) => this changes pid, node has to bind to the new pid and not start a duplicate process (also needs a grace period to handle the few secs when bot is starting and did not yet update its state file)
  2. when master is stopped, it stops child processes, when it's restarted, we want to instantly restart the child without waiting for any grace period (child is not "late", it's just hasnt been respawned yet)

@GuillaumeDSM GuillaumeDSM self-assigned this Jun 25, 2026
@GuillaumeDSM GuillaumeDSM requested a review from Herklos as a code owner June 25, 2026 09:44
"origin_package": "OctoBot-Default-Tentacles",
"tentacles": ["NodeWebInterface"],
"tentacles-requirements": ["node_api_interface"],
"build": ["npm install", "npm run generate-client", "npm run build"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups

@GuillaumeDSM GuillaumeDSM force-pushed the restart branch 3 times, most recently from 23d816e to 0cd2fc5 Compare June 25, 2026 17:53

DEFAULT_PORTFOLIO_VALUATION_UNIT = "USDT"

SCHEDULER_EXECUTOR_ID = str(uuid.uuid4()) # unique for each worker

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM force-pushed the restart branch 2 times, most recently from 337fb67 to 8d3dce8 Compare June 26, 2026 10:10
@GuillaumeDSM GuillaumeDSM merged commit 76bb311 into dev Jun 26, 2026
23 checks passed
@GuillaumeDSM GuillaumeDSM deleted the restart branch June 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants