amaci: harden signup/tally validation and clean up unused state#20
Open
99Kies wants to merge 10 commits into
Open
amaci: harden signup/tally validation and clean up unused state#2099Kies wants to merge 10 commits into
99Kies wants to merge 10 commits into
Conversation
99Kies
commented
Jun 11, 2026
99Kies
commented
Collaborator
- enforce pubkey uniqueness across all signup modes (unified SIGNUPED check)
- reject finalizing a zero-signup round with non-zero results; otherwise enforce a strict tally-commitment match
- use saturating_sub for elapsed-time calculations to avoid underflow
- restore start_time < end_time validation at instantiate
- cap StaticWhitelist by whitelist size so it works under the production circuit
- persist voice credit balance on key rotation (AddNewKey)
- remove unused state maps and the always-zero state-idx query/bindings
- add GetVkeys query and regenerate schema
- correct Uint32to96 high-chunk constant and add high-chunk coverage
- use Num2Bits_strict for canonical bit decomposition in ElGamal decrypt
- enforce pubkey uniqueness across all signup modes (unified SIGNUPED check) - reject finalizing a zero-signup round with non-zero results; otherwise enforce a strict tally-commitment match - use saturating_sub for elapsed-time calculations to avoid underflow - restore start_time < end_time validation at instantiate - cap StaticWhitelist by whitelist size so it works under the production circuit - persist voice credit balance on key rotation (AddNewKey) - remove unused state maps and the always-zero state-idx query/bindings - add GetVkeys query and regenerate schema - correct Uint32to96 high-chunk constant and add high-chunk coverage - use Num2Bits_strict for canonical bit decomposition in ElGamal decrypt
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Extract round verification into an event-driven pipeline (core/pipeline.ts) shared by the terminal renderer and a new local HTTP server with SSE. 'maci ui' serves a static web UI (no new runtime deps, 127.0.0.1 only) for round verification and circuit registry browsing.
Feature/cli web UI
- Update vkeys for both 2-1-1-5 (test) and 9-4-3-125 (production) circuits in contracts/amaci/src/circuit_params.rs - Sync vkeys and zkeyUrl (v3/v4 → v5) in packages/cli/src/core/circuits.ts, update SHA256 hashes for both tar archives - Update S3 download URLs and internal tar paths (v4 → v5) in e2e/scripts/downloadZkeys.ts and packages/circuits/ts/generate-logs.ts - Refresh e2e/circuits/vkeys-amaci-2-1-1-5.json with v5 vkey values - Regenerate logs.json for amaci and registry contract tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.