ci: add github-actions to publish multi-arch container#12
Open
oliverpool wants to merge 1 commit into
Open
Conversation
fee7dae to
844c97a
Compare
Contributor
Author
|
@pieterphilippaerts let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #10
Instead of using the
Dockerfile, this leverages thedotnet publishcommand to build multi-arch (x64 and arm64) container images.main, the container is built for x64 (smoke test, to ensure that the docker build is not broken)This works fine, but I had to adjust 2 aspects:
Sqlite DB path change
/appis owned by an user different from the user running the app, so the sqlite db can't be created there. I moved it to/home/app(this also allows consumers to set a volume for the whole/home/appwithout messing with the dll).Https -> http
Generating self-signed certs in a previous step is a bit hacky (self-signed certs are easy to misuse and the expiry date is like a time-bomb).
I think that https certs should be managed outside of the docker container (reverse-proxy for instance).
Since dotnet defaults to rootless containers, the app now accepts http requests on port 8080.
You can try the current state on https://github.com/oliverpool/OAuch/pkgs/container/oauch