Skip to content

ci: lint the whole workspace with clippy and add cargo-deny #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ci: lint the whole workspace with clippy and add cargo-deny #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db1c9de
ci: lint the whole workspace with clippy and add cargo-deny
mmorrissette-devolutions Jul 3, 2026
32562f5
fix(ffi): keep locking the mutex in online chunk functions
mmorrissette-devolutions Jul 3, 2026
fffa3a2
chore(deps): update Cargo.lock to latest compatible versions
mmorrissette-devolutions Jul 3, 2026
ad901e0
chore(deps): upgrade uniffi from 0.31 to 0.32
mmorrissette-devolutions Jul 3, 2026
9c065b4
refactor(cli): use the library base64 helpers instead of the base64 c…
mmorrissette-devolutions Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,19 @@ jobs:
- uses: actions/checkout@v6
- uses: ./.github/workflows/formatting/rust

#### DEPENDENCY AUDIT ####
cargo_deny:
runs-on: "ubuntu-22.04"

steps:
- uses: actions/checkout@v6

- name: Install cargo-deny
run: cargo install cargo-deny --locked

- name: Check dependencies
run: cargo deny check

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add licenses before enabling cargo-deny

The new cargo deny check job runs the licenses check, but several workspace members that this command inspects have no license/license-file in their manifests (cli/Cargo.toml, ffi/Cargo.toml, python/Cargo.toml, and the UniFFI crate all show license: null in cargo metadata). With the current deny.toml policy ([licenses.private].ignore = false) cargo-deny does not skip those workspace crates; its docs state unlisted/unlicensed crates fail unless explicitly allowed or clarified (licenses config). As a result, this newly added CI job will fail before it can audit dependencies unless the workspace crates inherit/add a license or are explicitly made private and skipped.

Useful? React with 👍 / 👎.


#### FUZZ TESTING ####
quick_fuzz:
runs-on: "ubuntu-22.04"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/formatting/rust/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ runs:
- name: Check Clippy
working-directory: ./
shell: bash
run: cargo clippy -- --D warnings
run: cargo clippy --workspace --all-targets -- -D warnings
Loading
Loading