docs(adr): correct ADR 0016 to the shipped 2.0 module layout#395
Merged
Conversation
Two statements in the multi-module packaging ADR described a superseded draft rather than what shipped: - Engine sources are in the `core/` module (coordinate `graph-compose-core`), not "at the repository root" — the root is the `graph-compose-build` aggregator pom that binds the reactor. - The dormant Entity-Component-System internals (EntityManager / SystemECS runtime, the Entity model, the ECS render pipeline) were removed in 2.0.0, not moved into a module with removal deferred. They were unreachable from the live render path, so layout, PDF output, and guideLines(...) are unchanged. Documentation guards (CanonicalSurface, DocumentationCoverage, PackageMap, VersionConsistency) stay green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two statements in ADR 0016 still described a superseded draft of the split rather than what actually shipped in 2.0.0, so a reader trusting the ADR would misunderstand the repository layout and believe dead code still lingers.
What
core/module under the coordinategraph-compose-core; the repository root is thegraph-compose-buildaggregator pom binding the reactor. The ADR previously claimed the sources "stay at the repository root" — the root has nosrc/main/java.EntityManager/SystemECSruntime, theEntitycomponent model, and the ECS render pipeline — were removed in 2.0.0, not "moved intograph-compose-render-pdf… removal deferred beyond 2.0." Zero files remain; the CHANGELOG v2.0.0 records the removal. They were unreachable from the liveDocumentSession→ layout compiler → fixed-layout backend path, so layout, PDF output, andguideLines(...)are unchanged.The §3 api-stability packaging ledger row already reads "landed 2.0 / Done in 2.0"; no change needed there.
Tests
Documentation guards green:
CanonicalSurfaceGuardTest,DocumentationCoverageTest,PackageMapGuardTest,VersionConsistencyGuardTest(27 tests, 0 failures).