init fix example

[JimyMa]

No description provided.

[gemini-code-assist]

Code Review

This pull request updates topology discovery to support TCP-only deployments by returning an empty topology instead of throwing an error when no RDMA devices are available. It also restricts local resource inspection to NICs openable by libibverbs and handles initialization failures gracefully. The reviewer feedback highlights critical compatibility and stability issues: first, available_nic should be imported gracefully to prevent ImportError on older binaries; second, check_openable must handle cases where available_nic is unavailable; and third, the fallback dictionary returned when discover_topology fails should include standard keys like host and schema_version to avoid downstream KeyError crashes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[JimyMa]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the topology discovery and peer agent to support TCP-only deployments by allowing empty RDMA device lists instead of throwing errors. It also ensures that only openable RDMA devices are selected by checking them against available_nic(), and prevents initialization crashes by setting _shutdown_called earlier. Feedback suggests caching the results of available_nic() to avoid redundant system calls and improve performance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Calling available_nic() on every invocation of _first_usable_resource_key when checking the local resource can be highly inefficient. available_nic() queries the system's RDMA devices (via ibv_get_device_list), which involves system calls and file I/O. Since the set of openable RDMA devices on a host is static during the lifetime of the agent, we can cache this set on the first call to avoid redundant system queries.

Suggested change

	check_openable = resource is self._local_resource
	openable = set(available_nic()) if check_openable else set()
	check_openable = resource is self._local_resource
	if check_openable:
	if not hasattr(self, "_openable_nics_cache"):
	self._openable_nics_cache = set(available_nic())
	openable = self._openable_nics_cache
	else:
	openable = set()