feat(parametric/java): activate FFE span-enrichment tests [java@typo/FFL-2224/ffe-span-enrichment]#7204
Draft
typotter wants to merge 2 commits into
Draft
feat(parametric/java): activate FFE span-enrichment tests [java@typo/FFL-2224/ffe-span-enrichment]#7204typotter wants to merge 2 commits into
typotter wants to merge 2 commits into
Conversation
Enable tests/parametric/test_ffe/test_span_enrichment.py for the Java tracer (DataDog/dd-trace-java#11658), which adds FFE APM feature-flag span enrichment behind DD_EXPERIMENTAL_FLAGGING_PROVIDER_SPAN_ENRICHMENT_ENABLED. - FeatureFlagEvaluatorController: re-activate the caller-supplied root span (span_id) around the OpenFeature evaluation so the ffe_* tags land on the test's root span. span_id arrives as a decimal string and is resolved via the OpenTracing registry (DDSpanId.from); unknown/unparsable ids skip activation and never throw. - manifests/java.yml: declare the enrichment suite at v1.64.0 (the release that ships the feature).
- Set manifest to v1.63.0-SNAPSHOT (all 18 tests passing) - Bump parametric JVM heap from 128M to 256M to avoid OOM under 16-worker parallelism - Fix zombie container crash in _clean_containers when Docker returns 404 on inspect
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Activates the frozen
tests/parametric/test_ffe/test_span_enrichment.pysuite for Java againstdd-trace-java#11658 (FFE APM span enrichment, gated behind
DD_EXPERIMENTAL_FLAGGING_PROVIDER_SPAN_ENRICHMENT_ENABLED).Supersedes #7150 (Leo's draft) — same approach, rebased on current main with infrastructure
fixes needed to get the full 18-test suite passing locally.
Changes
manifests/java.yml— declaretests/parametric/test_ffe/test_span_enrichment.pyat
v1.63.0-SNAPSHOT(SNAPSHOT so CI runs againstjava@typo/FFL-2224/ffe-span-enrichmentrather than xfailing; will be updated to the release version before merge).
utils/build/docker/java/parametric/run.sh— bump JVM heap from 128M to 256M toprevent OOM kills when 16 parametric workers run concurrently with span enrichment enabled.
utils/_context/_scenarios/_docker_fixtures.py— handledocker.errors.NotFoundin_clean_containers: Docker SDK'scontainers.list(all=True)can return container IDs thatno longer exist by the time
inspect_containeris called; fall back to raw API to avoida crash that prevented test cleanup between runs.
Validation
All 18 cases pass against
dd-java-agent 1.63.0-SNAPSHOT(dd-trace-java#11658,HEAD
109eab80bc). The 16-parallel-worker run surfaces a startup timeout under CPUcontention — confirmed all tests pass when run with
--dist no.