Mark list-of-oneOf with an invalid item as unparsed#4078
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80fbe0bc2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jack-edmonds-dd
left a comment
There was a problem hiding this comment.
approval for modelSimple.j2 (I'm assuming the rest of the changes are generated).
…model is unparsed.
|
@codex review |
💡 Codex ReviewFor optional array-of-model fields, this template now makes the generated fluent setter iterate the caller-provided value unconditionally. In generated methods such as When a BDD scenario response contains an ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c67b6d59a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What does this PR do?
Correctly fails to parse a
FormulaAndFunctionEventQueryDefinitionwhen it contains an invalidgroup_bylist entry.The code generator was failing to propagate
unparsedfrom aoneOfto its parent in this case.(DataDog's APIs don't generally return invalid objects, so this shouldn't affect users. The value comes with an upcoming PR, where a
oneOfitem contains a list which contains anotheroneOfitem. In that case, we need to detect invalid objects from the inneroneOf.)Review checklist
Please check relevant items below: