♻️ refactor modifiable field paths in rum assembly#4687
Merged
Conversation
move shared beforeSend modifiable paths into a common constant and define event-specific paths in a single static map. this removes duplicated per-event setup in startRumAssembly and keeps the allowed field list easier to maintain without changing behavior.
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 77f4a4d | Docs | Datadog PR Page | Give us feedback! |
mormubis
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
simplify maintenance of
beforeSendmodifiable fields and reduce bundle size a bit.Changes
RumEventType.VIEW_UPDATEvariantTest instructions
yarn dev.beforeSendto modify allowed fields (for exampleview.urlorerror.message) and verify sent events are updated.falseinbeforeSendfor a non-view event (dropped) and for a view event (not dropped).Checklist