fix(waterdata)!: return (df, BaseMetadata) from get_codes#301
Merged
thodson-usgs merged 1 commit intoJun 1, 2026
Merged
Conversation
Every other public waterdata getter returns a (DataFrame, BaseMetadata) tuple, but get_codes returned a bare DataFrame, so the module's universal idiom `df, md = waterdata.get_codes(...)` raised an unpack error. It already builds `response` (and calls _raise_for_non_200), so the metadata was in hand and discarded. BREAKING: callers doing `df = get_codes(...)` must switch to `df, _ = get_codes(...)`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_codesis the only publicwaterdatagetter that returns a bareDataFrameinstead of the module-wide(DataFrame, BaseMetadata)tuple. So the universal idiom every other getter supports —— breaks, even though
get_codesalready buildsresponseand calls_raise_for_non_200(response)(the metadata is in hand, just discarded).Fix
Return
(df, BaseMetadata(response)), matchingget_reference_tableand every other getter.Verification (live API)
ruffclean.🤖 Generated with Claude Code