Skip to content

Fix PFC on root level elements#2280

Merged
spenke91 merged 8 commits into
mainfrom
fix-pfc_root_level
Jun 17, 2026
Merged

Fix PFC on root level elements#2280
spenke91 merged 8 commits into
mainfrom
fix-pfc_root_level

Conversation

@Niklas997

@Niklas997 Niklas997 commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Closes #2281

Describe your changes here:

When partition for coarsening is applied and the border element is a root level element, a PFC-Message is constructed and the parent element therein is the actual pointer to the root element in the mesh. Upon destruction of the PFC-Message, the parent element (in this case the actual root element in the mesh) is destroyed. In all other cases (i.e. the border element is not a root element) additional storage for the parent is allocated and it is filled with the corresponding information and this newly constructed element will be deallocated within the destructor. Currently, this leads to a crash in case the partition boundary falls on a root element. In order to account for this, there needs to be an additional element-allocation for the parent in the root level case as well which is then filled by an element_copy of the actual root element, such that it can be safely dealloacted upon destruction of the mesasge.

In order to re-create the issue, one can just construct a uniform forest with refinement level 0 from a cmesh and call partiton for caoarsening on it.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Niklas997 Niklas997 added Bug For a bug in the Code priority:high Should be solved as soon as possible labels Apr 17, 2026
@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.37%. Comparing base (0d30a0b) to head (3d565a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
+ Coverage   82.34%   82.37%   +0.02%     
==========================================
  Files         125      125              
  Lines       20543    20543              
==========================================
+ Hits        16917    16922       +5     
+ Misses       3626     3621       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spenke91 spenke91 self-assigned this Apr 17, 2026
@spenke91 spenke91 self-requested a review April 20, 2026 08:40

@spenke91 spenke91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this! :-) I just have one minor suggestion, hope you don't mind...

Comment thread src/t8_forest/t8_forest_pfc_message.hxx Outdated
@Niklas997 Niklas997 assigned spenke91 and unassigned Niklas997 Jun 15, 2026
@spenke91 spenke91 self-requested a review June 17, 2026 09:31

@spenke91 spenke91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spenke91 spenke91 enabled auto-merge June 17, 2026 09:41
@spenke91 spenke91 added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 135a18e Jun 17, 2026
40 checks passed
@spenke91 spenke91 deleted the fix-pfc_root_level branch June 17, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug For a bug in the Code priority:high Should be solved as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix PFC on root level elements

2 participants