Allow Ptr::offset() to receive any value that can cast to isize#213
Merged
Conversation
FranciscoTGouveia
force-pushed
the
offset-try-isize
branch
from
cc91f24 to
51de3cf
Compare
lucic71
approved these changes
Jun 30, 2026
The rationale behind this change is to avoid unnecessary casts that may hurt readability, such as: `0_usize as isize`. With this change, we are allowed to omit the cast, as it will be performed inside the `offset` function. This also has the advantage of panicking whenever we try to cast a usize larger than `isize::MAX`.
FranciscoTGouveia
force-pushed
the
offset-try-isize
branch
from
4b56eec to
9a5ef1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale behind this change is to avoid unnecessary casts that may hurt readability, such as:
0_usize as isize.With this change, we are allowed to omit the cast, as it will be performed inside the
offsetfunction.This also has the advantage of panicking whenever we try to cast a usize larger than
isize::MAX.