Avoid hoisting for function call arguments that don't alias#203
Merged
Conversation
nunoplopes
reviewed
Jun 23, 2026
| vars.insert(decl_ref->getDecl()); | ||
| } else if (auto *member = clang::dyn_cast<clang::MemberExpr>(stmt)) { | ||
| vars.insert(member->getMemberDecl()); | ||
| auto child_vars = GetAllVars(member->getBase()); |
Contributor
There was a problem hiding this comment.
It's better to split this method in two: one that returns the set (just calls the 2nd function), and another that returns void and received an additional set parameter and adds stuff there.
This avoid allocating an extra set on the recursive call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In terms of converter, the PR is small. I moved GetAllVars and MayCauseBorrowMutError from converter to converter_lib because they are converter-agnostic. Then I added the aliasing logic in CollectCallInfo 2 functions in converter_lib: ReferencesThis and ArgsMayAlias.
The core idea is: if an argument of a function call does not alias with any other argument, then it can be inlined instead of hoisted. This includes aliases over this, for example
this.method(this.member)