Skip to content

Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab Connector#95

Closed
mateoHernandez123 wants to merge 1 commit into
mainfrom
mateoHernandez123/fix-main-ci-go-version
Closed

Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab Connector#95
mateoHernandez123 wants to merge 1 commit into
mainfrom
mateoHernandez123/fix-main-ci-go-version

Conversation

@mateoHernandez123

Copy link
Copy Markdown
Contributor

Description

  • Bug fix (CI)

Removes the legacy .github/workflows/main.yaml ("main ci") workflow, which has been failing on every push to main since baton-admin bumped the Go version.

Problem

main.yaml ran go-lint + go-test on push to main with a hardcoded go-version: 1.23.x. After .versions.yaml/go.mod moved to go 1.25.2, the 1.23.x runner sees a newer go directive, auto-downloads the 1.25.2 toolchain, and that toolchain switch breaks the coverage run:

go: downloading go1.25.2
go: no such tool "covdata"
##[error]Process completed with exit code 1

The workflow ran green for ~11 months and only started failing after the Go bump — it's stale, not intrinsically broken.

Why remove instead of fix

The managed Verify workflow already runs lint + test + docs on push to main (and on PRs) via the shared ConductorOne/github-workflows/verify.yaml, and it reads the Go version from go.mod, so it's green. main.yaml is fully redundant with Verify.

Reference check across the org: 423 of 478 connectors have no main.yaml at all and rely on Verify for exactly this coverage. Removing it:

  • fixes the recurring red on main,
  • deletes a drift-prone hardcoded Go version that will rot again on the next bump,
  • keeps identical check coverage (lint + test still run on push and PR via Verify).

Scope

  • Delete .github/workflows/main.yaml only. No code, dependency, or managed-file changes. No other workflow references it.

main.yaml (name "main ci") ran go-lint + go-test on push to main with a
hardcoded go-version: 1.23.x. After baton-admin bumped .versions.yaml/go.mod
to go 1.25.2, the 1.23.x runner auto-downloads the newer toolchain and
`go test -covermode=count` fails with `go: no such tool "covdata"` — the
workflow has been red on every push to main since the bump.

The managed Verify workflow already runs lint + test + docs on push to main
(and on PRs) via the shared ConductorOne/github-workflows verify.yaml, so
main.yaml is fully redundant. 423/478 org connectors have no main.yaml and
rely on Verify. Removing it fixes the recurring red and eliminates the
drift-prone hardcoded Go version.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab Connector

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 3ccb0753efce.
Review mode: full
View review run: https://github.com/ConductorOne/baton-gitlab/actions/runs/29612704114

Review Summary

The full PR diff was scanned for security and correctness. This PR only deletes the legacy .github/workflows/main.yaml ("main ci") workflow; it touches no Go source, dependencies, or managed files. I verified the equivalence claim: the managed verify.yaml runs on push to main and on PRs via the shared ConductorOne/github-workflows workflow and reads the Go version from go.mod, so lint/test check coverage is preserved. No other file references the deleted workflow. No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@mateoHernandez123

Copy link
Copy Markdown
Contributor Author

Closing in favor of #94 (luisina-santos), which was opened first and is more complete — besides removing main.yaml it moves the push-to-main lint/test coverage into the connector's own ci.yaml (and scopes test-cloud-version to PRs). Same root cause fixed there: main ci pinned go-version: 1.23.x while go.mod moved to 1.25.2, so the runner auto-downloaded the toolchain and go test -covermode=count failed with go: no such tool "covdata" on every push to main. Resolved by #94.

@mateoHernandez123
mateoHernandez123 deleted the mateoHernandez123/fix-main-ci-go-version branch July 17, 2026 20:53

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants