Skip to content

Fix/windows conpty ansi leak #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyaxuwu wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −9
Open

Fix/windows conpty ansi leak #857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56c32b
Update run-terminal-command.ts
ilyaxuwu Jul 9, 2026
16b3327
Merge branch 'main' of https://github.com/CodebuffAI/codebuff
ilyaxuwu Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions sdk/src/tools/run-terminal-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,16 @@ export function runTerminalCommand({
cwd: resolvedCwd,
env: processEnv,
stdio: 'pipe',
// On POSIX, give the command its own process group so that killing it
// (timeout or user abort) also kills any grandchild processes.
detached: !isWindows,
// On Windows, give the child its own invisible console (CREATE_NO_WINDOW)
// instead of attaching it to the TUI's console. Console-attached
// descendants can open CONIN$/CONOUT$ directly (cmd, pause, choice,
// PSReadLine, ...) even when stdio is piped, stealing the VT input that
// ConPTY generates for the TUI's mouse/focus tracking and echoing it as
// gibberish like `^[[I^[[<35;12;7M` painted over the UI.
// Give the command its own process group so that killing it (timeout or
// user abort) also kills any grandchild processes. On POSIX this uses a
// negative pid kill against the process group. On Windows `detached: true`
// maps to DETACHED_PROCESS, which combined with CREATE_NO_WINDOW (from
// windowsHide) completely detaches the child from the parent's console.
// Without DETACHED_PROCESS, console-attached descendants can open
// CONIN$/CONOUT$ directly even when stdio is piped, stealing the VT input
// that ConPTY generates for the TUI's mouse/focus tracking and echoing it
// as gibberish like `^[[I^[[<35;12;7M` painted over the UI.
detached: true,
windowsHide: true,
})

Expand Down