fix: harden Windows AVX2 probe#828
Open
vamshikrishnaramasamy wants to merge 1 commit into
Open
Conversation
|
Thanks for the quick fix and for updating the documentation! I’ll test it on my Windows 11 machine with an Intel Core i5-3570 (AVX, no AVX2) as soon as the new version is available and report back if everything works as expected. |
Author
|
Thanks! That would be super helpful. This PR should make the launcher choose the baseline binary more reliably on non AVX2 CPUs, so your i5 3570 is exactly the kind of machine worth validating on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #822.
Updates the Windows AVX2 PowerShell probe used by the CLI launchers. The probe now uses the fully qualified DllImport attribute and ErrorAction Stop, making failures explicit so non-AVX2 machines are less likely to incorrectly proceed with the optimized win32-x64 binary instead of the baseline target.\n\nValidation:\n- node --check freebuff/cli/release/index.js\n- node --check cli/release/index.js\n- node --check cli/release-staging/index.js\n\nNote: I verified syntax locally on macOS, but could not run the Windows PowerShell probe directly on this machine.